Skip to content

feat(docker): Improve docker build and prevent double path in naming#268

Merged
goneall merged 2 commits intospdx:masterfrom
heliocastro:fix/docker_placement
Jan 19, 2026
Merged

feat(docker): Improve docker build and prevent double path in naming#268
goneall merged 2 commits intospdx:masterfrom
heliocastro:fix/docker_placement

Conversation

@heliocastro
Copy link
Contributor

@heliocastro heliocastro commented Jan 17, 2026 •
edited
Loading

  • Push the image to spdx/ organiztion level, so removing the duplicated path
  • Enable docker to be built manually or on pull requests for test, but push is only enabled on tagging
  • Move artificial version delaration to maven proper solution
  • Add multiarch build
  • Upxate Maven to version 3.9 and base Java for version 21
  • Pinned actions for docker based actions

@heliocastro heliocastro marked this pull request as draft January 17, 2026 14:46
@bact bact added the enhancement New feature or request label Jan 17, 2026
@goneall
Copy link
Member

goneall commented Jan 17, 2026

Looks like the CI is failing with the following:

70.93 cp: cannot stat 'target/tools-java-268/merge-jar-with-dependencies.jar': No such file or directory
------
WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
ERROR: failed to build: failed to solve: process "/bin/sh -c mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent install     && mkdir -p /usr/lib/java/spdx     && cp target/tools-java-$TOOLS_JAVA_VERSION-jar-with-dependencies.jar /usr/lib/java/spdx/" did not complete successfully: exit code: 1
Reference
Check build summary support
Error: buildx failed with: ERROR: failed to build: failed to solve: process "/bin/sh -c mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent install     && mkdir -p /usr/lib/java/spdx     && cp target/tools-java-$TOOLS_JAVA_VERSION-jar-with-dependencies.jar /usr/lib/java/spdx/" did not complete successfully: exit code: 1

@heliocastro
Copy link
Contributor Author

heliocastro commented Jan 18, 2026

Looks like the CI is failing with the following:

Still on draft, i'll finish now, as the daily coffee start to make effect :-)

@heliocastro heliocastro marked this pull request as ready for review January 18, 2026 10:29
@heliocastro
Copy link
Contributor Author

heliocastro commented Jan 18, 2026 •
edited
Loading

@goneall We are good to go
I made more improvements than only push to spdx/tools-java.
When you tag a release, the push to main registry will happens and latest tag will be added automatically.
The build are a little slow now due multiarch image, it need build twice for amd64 and arm64, this is because the way docker build actions works unfortunately, but as java itself we could reuse it if not that.

@goneall goneall merged commit 0e188d5 into spdx:master Jan 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goneall goneall goneall approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heliocastro @goneall @bact